検索

💬 Commented on "iOS版BraveでMisskey各種ページの読み込みに失敗する問題": kokage47 "ご返信ありがとうございます。要因の特定に難航しておりましたが、おかげさまで一つきっかけが掴めたように思います。
報告につきましてはこちらからBrave側にレポートさせていただきます。ありがとうございました。" https://github.com/misskey-dev/misskey/issues/18004#issuecomment-6093346492
返信 0 · Renote 0
💬 Commented on "iOS版BraveでMisskey各種ページの読み込みに失敗する問題": anatawa12 "braveブラウザのソースコードを漁ったところ、`window.etherium.selectedAddress = <value>` というコードがinjectされることを確認できました。そのため、braveブラウザのUnhandled Rejection/exceptionを発生させるバグである可能性が高いと私は考えます。

Unhandled Rejectionが発生したときにどのようなエラーハンドリングを行うかはアプリケーションによってことなり、misskeyはさらなる問題を避けるためなどの理由で動作を止めるようになっているため、misskeyでのみ発生するように見えていると考えられます" https://github.com/misskey-dev/misskey/issues/18004#issuecomment-6093261529
返信 0 · Renote 0
💬 Commented on "iOS版BraveでMisskey各種ページの読み込みに失敗する問題": kokage47 "まあ、自分もクライアントアプリ入れれば済む話だとは思ってるんですがねぇ…
SNSアカウントを複数運用している身としては、普段使ってるブラウザで全て完結するのが一番なわけで
スマホのホーム画面をSNSアプリで埋め尽くしたいわけじゃないですし…" https://github.com/misskey-dev/misskey/issues/18004#issuecomment-6091650633
返信 0 · Renote 0
💬 Commented on "iOS版BraveでMisskey各種ページの読み込みに失敗する問題": sinzai "ぼくも brave と safari を使用していますが、ぼくの環境でもアクセスできないことが確認できました。safari では通常通り使用できたので、おま環ではないと思います。
まぁ正直、そもそも以前から brave では広告ブロックオフにしないと使用できなかったし、わざわざ brave にこだわる必要ないんじゃないかな...と。" https://github.com/misskey-dev/misskey/issues/18004#issuecomment-6091527811
返信 0 · Renote 0
💬 Commented on "feat(frontend): カスタム絵文字管理画面(β)の登録タブにドロップで絵文字を登録できるエリアを追加": codecov[bot] "## [Codecov](https://app.codecov.io/gh/misskey-dev/misskey/pull/18005?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 14.25%. Comparing base ([`53ac680`](https://app.codecov.io/gh/misskey-dev/misskey/commit/53ac6808ae4921305e761c545863ee6593edd1f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev)) to head ([`265f636`](https://app.codecov.io/gh/misskey-dev/misskey/commit/265f6364b44b0d6aa6012a84840177cb731a88f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev)).

<details><summary>Additional details and impacted files</summary>



```diff
@@ Coverage Diff @@
## develop #18005 +/- ##
============================================
- Coverage 51.71% 14.25% -37.47%
============================================
Files 1202 251 -951
Lines 40941 11998 -28943
Branches 11630 4040 -7590
============================================
- Hits 21174 1710 -19464
+ Misses 16119 8067 -8052
+ Partials 3648 2221 -1427
```
</details>

[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/misskey-dev/misskey/pull/18005?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev).
<details><summary> :rocket: New features to boost your workflow: </summary>

- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>" https://github.com/misskey-dev/misskey/pull/18005#issuecomment-6062794842
返信 0 · Renote 0
💬 Commented on "fix: ログイントークン再生成時に二要素認証が検証されない問題を修正": github-actions[bot] "## ⚙️ Backend Diagnostics Report

### Memory: After GC
**(No significant changes)**


### V8 Heap Snapshot Statistics

| Metric | @&nbsp;Base | @&nbsp;Head | Δ | MAD |
| --- | ---: | ---: | ---: | ---: |
| $\color{gray}{\rule{8pt}{8pt}}$ **Total** | 86 MB <br> ± 7 KB | 86 MB <br> ± 4.3 KB | $\text{-22 KB}$<br>$\text{-0\\%}$ | 8.2 KB |
| | | | | |
| $\color{orange}{\rule{8pt}{8pt}}$ **Code** | 25 MB | 25 MB | $\text{-23 KB}$ | 7.1 KB |
| $\color{red}{\rule{8pt}{8pt}}$ **Strings** | 30 MB | 30 MB | $\text{-2.8 KB}$ | 851 B |
| $\color{cyan}{\rule{8pt}{8pt}}$ **JS arrays** | 4.4 MB | 4.4 MB | $\text{+8 B}$ | 0 B |
| $\color{green}{\rule{8pt}{8pt}}$ **Typed arrays** | 566 KB | 566 KB | 0 B | 0 B |
| $\color{yellow}{\rule{8pt}{8pt}}$ **System objects** | 2.3 MB | 2.2 MB | $\text{-560 B}$ | 1.9 KB |
| $\color{violet}{\rule{8pt}{8pt}}$ **Other JS objs** | 24 MB | 24 MB | $\text{-232 B}$ | 149 B |
| $\color{pink}{\rule{8pt}{8pt}}$ **Other non-JS objs** | 39 KB | 39 KB | 0 B | 0 B |


Download representative heap snapshot: [base](https://github.com/misskey-dev/misskey/actions/runs/37646680559/artifacts/11494898788) / [head](https://github.com/misskey-dev/misskey/actions/runs/37646680559/artifacts/11494788780)


<!-- thollander/actions-comment-pull-request "show_memory_diff" -->" https://github.com/misskey-dev/misskey/pull/18003#issuecomment-6041600263
返信 0 · Renote 0
💬 Commented on "fix: ログイントークン再生成時に二要素認証が検証されない問題を修正": github-actions[bot] "このPRによるapi.jsonの差分
<details>
<summary>差分はこちら</summary>

```diff
--- base
+++ head
@@ -60350,6 +60350,12 @@
"properties": {
"password": {
"type": "string"
+ },
+ "token": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
```
[Get diff files from Workflow Page](https://github.com/misskey-dev/misskey/actions/runs/37646908203)

<!-- thollander/actions-comment-pull-request "show_diff" -->" https://github.com/misskey-dev/misskey/pull/18003#issuecomment-6041490489
返信 0 · Renote 0
💬 Commented on "fix: ログイントークン再生成時に二要素認証が検証されない問題を修正": codecov[bot] "## [Codecov](https://app.codecov.io/gh/misskey-dev/misskey/pull/18003?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 15.44%. Comparing base ([`5f50134`](https://app.codecov.io/gh/misskey-dev/misskey/commit/5f501341d49d2bc3fa7e817ce7548a82174326eb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev)) to head ([`501ef57`](https://app.codecov.io/gh/misskey-dev/misskey/commit/501ef57ea95dd9443e1203912ab775f950033c8d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev)).

<details><summary>Additional details and impacted files</summary>



```diff
@@ Coverage Diff @@
## develop #18003 +/- ##
===========================================
+ Coverage 14.18% 15.44% +1.25%
===========================================
Files 250 252 +2
Lines 11989 12202 +213
Branches 4037 4079 +42
===========================================
+ Hits 1701 1884 +183
- Misses 8067 8096 +29
- Partials 2221 2222 +1
```
</details>

[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/misskey-dev/misskey/pull/18003?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=misskey-dev).
<details><summary> :rocket: New features to boost your workflow: </summary>

- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>" https://github.com/misskey-dev/misskey/pull/18003#issuecomment-6041483029
返信 0 · Renote 0
💬 Commented on "Avoid planning notes in the past": Andrew-Velox "Hi, I'd like to work on this. Could a committer assign it to me, or let me know if the approach below needs changes?

Cause: in MkPostForm.vue, schedule() does if (result.getTime() <= Date.now()) return;, so a past time is silently ignored. The backend already rejects past times, so this is only a frontend UX gap.

Proposed fix (frontend only):
1. Add an optional min to the input options in MkDialog.vue and pass it to MkInput, so the datetime-local picker disables past dates.
2. Disable the OK button and show a short caption when the entered time is in the past. This is needed because min doesn't stop hand-typed values.
3. Make os.inputDatetime accept min, and pass the current time from MkPostForm.vue.
4. Add one new string to locales/ja-JP.yml for the caption (the other locales are left to Crowdin). " https://github.com/misskey-dev/misskey/issues/17960#issuecomment-6040083169
返信 0 · Renote 0